02.09 TIL
2023. 2. 9. 21:23ㆍ개발일지
오늘은 시험을 봤습니다. 매니저님이 오셔서 List형식으로 안받았다는 말씀에 확인해보니
package com.example.test.service;
import com.example.test.dto.MemberResponseDto;
import com.example.test.entity.Member;
import com.example.test.repository.MemberRepository;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
@Service
@RequiredArgsConstructor
public class MemberService {
private final MemberRepository memberRepository;
@Transactional(readOnly = true)
public List<MemberResponseDto> findAllMember() {
return memberRepository.findAllByOrderByModifiedAtDesc();
}
@Transactional
public MemberResponseDto findMember(Long id) {
return memberRepository.findById(id).map(MemberResponseDto::new).orElseThrow(
() -> new NullPointerException("회원 상세 조회 실패 했습니다.")
);
}
}
진짜네... 그래서 죄송하다고 전하고 바로
package com.example.test.service;
import com.example.test.dto.MemberResponseDto;
import com.example.test.entity.Member;
import com.example.test.repository.MemberRepository;
import lombok.RequiredArgsConstructor;
import org.springframework.stereotype.Service;
import org.springframework.transaction.annotation.Transactional;
import java.util.ArrayList;
import java.util.List;
@Service
@RequiredArgsConstructor
public class MemberService {
private final MemberRepository memberRepository;
// @Transactional(readOnly = true)
// public List<MemberResponseDto> findAllMember() {
// return memberRepository.findAllByOrderByModifiedAtDesc();
// }
@Transactional(readOnly = true)
public List<MemberResponseDto> findAllMember() {
List<Member> members = memberRepository.findAll();
List<MemberResponseDto> memberResponseDtos = new ArrayList<>();
for (Member b: members) {
memberResponseDtos.add(new MemberResponseDto(b));
}
return memberResponseDtos;
}
@Transactional
public MemberResponseDto findMember(Long id) {
return memberRepository.findById(id).map(MemberResponseDto::new).orElseThrow(
() -> new NullPointerException("회원 상세 조회 실패 했습니다.")
);
}
}
이렇게 수정해서 컨펌받았습니다.
자나깨나 코드조심 다시한번 느꼈습니다 작성 후 코드를 다시 보자!
'개발일지' 카테고리의 다른 글
02.11 ResponseEntity (0) | 2023.02.11 |
---|---|
02.10 JWT 저장 (쿠키, Local storage, Session storage) (0) | 2023.02.10 |
02.08 JPA 심화 (0) | 2023.02.08 |
02.07 TIL (0) | 2023.02.07 |
02.06 JPA 기초 (0) | 2023.02.06 |